[webkit-reviews] review denied: [Bug 83842] Web Inspector: add inspector instrumentation interface for compositing : [Attachment 137011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 00:58:39 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 83842: Web Inspector: add inspector instrumentation interface for
compositing
https://bugs.webkit.org/show_bug.cgi?id=83842

Attachment 137011: Patch
https://bugs.webkit.org/attachment.cgi?id=137011&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137011&action=review


> Source/WebCore/inspector/front-end/TimelineModel.js:53
> +    CompositeLayers: "CompositeLayers",

You need to update a test with it.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:-73
> -    recordStyles[recordTypes.BeginFrame] = { title:
WebInspector.UIString("Frame Start"), category: categories["rendering"] };

Why did this move?


More information about the webkit-reviews mailing list