[webkit-reviews] review granted: [Bug 83859] LocalizedDateICU should ignore timezones : [Attachment 137038] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 83859: LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859

Attachment 137038: Patch
https://bugs.webkit.org/attachment.cgi?id=137038&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137038&action=review


Looks good.  Picked a few nits.

> Source/WebCore/platform/text/LocalizedDateICU.cpp:48
> +    const UChar gmtTimezone[3] = {'G', 'M', 'T'};

Don't we need L prefix for each char?

> Source/WebCore/platform/text/LocalizedDateICU.cpp:50
> +    return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(),
gmtTimezone, 3, 0, -1, &status);

We could use WTF_ARRAY_LENGTH?