[webkit-reviews] review granted: [Bug 83838] Prepare submitForm for seamless navigation : [Attachment 137006] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 18:35:01 PDT 2012

Ryosuke Niwa <rniwa at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 83838: Prepare submitForm for seamless navigation

Attachment 137006: Patch

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137006&action=review

> Source/WebCore/loader/FrameLoader.cpp:317
> +    Frame* targetFrame = findFrameForNavigation(submission->target(),
>      if (!targetFrame) {
>	   if (!DOMWindow::allowPopUp(m_frame) &&
>	       return;

Can we flip the if-else below so that we can declare targetFrame inside the if?

More information about the webkit-reviews mailing list