[webkit-reviews] review granted: [Bug 83649] [chromium] Ensure RateLimiter waits for Swapbuffers completion : [Attachment 137002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 18:28:34 PDT 2012

James Robinson <jamesr at chromium.org> has granted John Bauman
<jbauman at chromium.org>'s request for review:
Bug 83649: [chromium] Ensure RateLimiter waits for Swapbuffers completion

Attachment 137002: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137002&action=review


> Source/WebCore/platform/graphics/chromium/RateLimiter.h:54
> +    explicit RateLimiter(GraphicsContext3D*, RateLimiterClient*);

no explicit for 2-arg c'tors

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:219
> +    void rateLimit();

this is overriding RateLimitClient::rateLimit(), right? would you mind adding
virtual and OVERRIDE keywords and documenting what it's overriding here
explicitly? (with a short "// RateLimitClient implementation." comment or the

More information about the webkit-reviews mailing list