[webkit-reviews] review granted: [Bug 83835] window.open should prepare for seamless navigation by using findFrameForNavigation : [Attachment 137000] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 83835: window.open should prepare for seamless navigation by using
findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835

Attachment 137000: Patch
https://bugs.webkit.org/attachment.cgi?id=137000&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137000&action=review


> Source/WebCore/loader/FrameLoader.cpp:2947
> +	   // FIXME: Eventually all callers should supply the actual
activeDocument
> +	   // so we can call canNavigate with the right document.

OMG! This might be the culprit of the bug I've been haunting for ages.