[webkit-reviews] review granted: [Bug 82974] Add Encrypted Media Extensions events to HTMLMediaElement : [Attachment 136797] Avoid using uninitialized mediaKeyErrorCode (exposed by removing default case)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 14:49:50 PDT 2012


Adam Barth <abarth at webkit.org> has granted David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 82974: Add Encrypted Media Extensions events to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974

Attachment 136797: Avoid using uninitialized mediaKeyErrorCode (exposed by
removing default case)
https://bugs.webkit.org/attachment.cgi?id=136797&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136797&action=review


This looks pretty straightforward.  Thanks.

> Source/WebCore/html/MediaKeyEvent.idl:37
> +	   readonly attribute [InitializedByEventConstructor] DOMString
defaultUrl;

Is this really supposed to be defaultUrl and not defaultURL ?  I though
capitalizing URL was idiomatic in the platform.  (I could be misremembering.)


More information about the webkit-reviews mailing list