[webkit-reviews] review granted: [Bug 83737] Inline StringImpl::find(UChar, ...) : [Attachment 136803] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 83737: Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737

Attachment 136803: Patch
https://bugs.webkit.org/attachment.cgi?id=136803&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136803&action=review


r=me

> Source/WTF/wtf/text/StringImpl.cpp:-780
> -size_t StringImpl::find(UChar c, unsigned start)

It looks like this code sometimes used "index" and sometimes used "start" for
this argument name. FWIW, I slightly prefer "start" over "index", since it's
more precise.

> Source/WTF/wtf/text/StringImpl.h:484
> +    inline size_t find(UChar character, unsigned index = 0);

No need for "inline" here.