[webkit-reviews] review denied: [Bug 83777] Introduce MenuItemID to autofill popup : [Attachment 136895] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 83777: Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777

Attachment 136895: Patch
https://bugs.webkit.org/attachment.cgi?id=136895&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136895&action=review


> Source/WebKit/chromium/public/WebAutofillClient.h:43
> +    enum {

nit: we usually name enums, and then we use the enum name
as the typename elsewhere.

shouldn't didAcceptAutofillSuggestion use a named enum type
for the itemID parameter?

please also see:
http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

> Source/WebKit/chromium/public/WebView.h:364
> +	   const WebVector<int>& itemIDs) = 0;

Chrome doesn't yet call this function?	It is easy to land without breaking
Chrome?