[webkit-reviews] review granted: [Bug 83786] Web Inspector: Line number is not displayed while debugging javascript : [Attachment 136920] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 12 13:15:16 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has granted Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 83786: Web Inspector: Line number is not displayed while debugging
javascript
https://bugs.webkit.org/show_bug.cgi?id=83786
Attachment 136920: Patch
https://bugs.webkit.org/attachment.cgi?id=136920&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136920&action=review
> Source/WebCore/ChangeLog:13
> + * inspector/front-end/Images/breakpointConditionalCounterBorder.png:
Double-checking that you've preserved the image dimensions. You should also
make sure your changes play nicely with present border image offsets.
> Source/WebCore/inspector/front-end/textViewer.css:141
> + color: #8E0504;
we typically use rgb() notation for color definitions. Could you please fix it
before landing?
More information about the webkit-reviews
mailing list