[webkit-reviews] review denied: [Bug 83156] [WIN] Simplify implementation of currentTime() : [Attachment 136262] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83156: [WIN] Simplify implementation of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=83156

Attachment 136262: Patch
https://bugs.webkit.org/attachment.cgi?id=136262&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136262&action=review


> Source/WTF/wtf/CurrentTime.cpp:86
> +    ULONGLONG dateTime = (static_cast<ULONGLONG>(fileTime.dwHighDateTime) <<
32) | fileTime.dwLowDateTime;

I think it would be nicer to copy fileTime into a ULARGE_INTEGER (without using
a union) and then use its QuadPart member. That's what MSDN recommends. Sorry
for not being more explicit before.