[webkit-reviews] review denied: [Bug 83436] [WIN] Use GetDateFormat and GetTimeFormat instead of strftime : [Attachment 136154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 12:22:49 PDT 2012

Adam Roben (:aroben) <aroben at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83436: [WIN] Use GetDateFormat and GetTimeFormat instead of strftime

Attachment 136154: Patch

------- Additional Comments from Adam Roben (:aroben) <aroben at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136154&action=review

> Source/JavaScriptCore/runtime/DatePrototype.cpp:233
> +    UChar buffer[128];

How do we know this is long enough? Maybe we should use something like
Vector<UChar, 128> and grow it if it turns out to be too small.

More information about the webkit-reviews mailing list