[webkit-reviews] review denied: [Bug 83762] [chromium] Introduce WebDataListElement : [Attachment 136882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 06:34:19 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 83762: [chromium] Introduce WebDataListElement
https://bugs.webkit.org/show_bug.cgi?id=83762

Attachment 136882: Patch
https://bugs.webkit.org/attachment.cgi?id=136882&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review


r- because of unrelated indentation fix.

> Source/WebKit/chromium/ChangeLog:14
> +	   * public/WebInputElement.h: Fix indentation.

Please do not fix indentation in this patch.

> Source/WebKit/chromium/public/WebInputElement.h:90
> +    WEBKIT_EXPORT WebDataListElement dataList() const;
> +

We won't need WebDataListElement if we introduce just "WebNodeCollection
dataListOptions()" to WebInputElement.	What do you think?


More information about the webkit-reviews mailing list