[webkit-reviews] review granted: [Bug 83472] Implement Dictionary.h on mac : [Attachment 136852] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 02:02:54 PDT 2012

Kentaro Hara <haraken at chromium.org> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 83472: Implement Dictionary.h on mac

Attachment 136852: Patch

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136852&action=review

> Source/WebCore/bindings/js/JSDictionary.h:120
> +bool JSDictionary::valueForProperty(const char* propertyName, Result&
finalResult) const

Nit: Maybe this can be renamed to JSDictionary::get(), for naming consistency
with Dictionary::get(). It's up to you.

More information about the webkit-reviews mailing list