[webkit-reviews] review granted: [Bug 83428] [Qt][WK2] Zoom gesture with double tap crashes on iframe when main frame has scroll offset. : [Attachment 136716] Patch

Thu Apr 12 01:32:43 PDT 2012

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zalan Bujtas
<zbujtas at gmail.com>'s request for review:
Bug 83428: [Qt][WK2] Zoom gesture with double tap crashes on iframe when main
frame has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=83428

Attachment 136716: Patch
https://bugs.webkit.org/attachment.cgi?id=136716&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136716&action=review

> Source/WebCore/testing/Internals.cpp:650
> +void Internals::setDelegatesScrolling(bool enabled, Document* document,
ExceptionCode& ec)

Nice!

> LayoutTests/touchadjustment/iframe-with-mainframe-scroll-offset.html:1
> +<html>

Shouldn\t the name of this file indicate that it is using scroll delegation? or
subdir?