[webkit-reviews] review denied: [Bug 83742] Implement DataList UI for chromium : [Attachment 136823] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 83742: Implement DataList UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=83742

Attachment 136823: Patch
https://bugs.webkit.org/attachment.cgi?id=136823&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136823&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   Implement DataList UI for chromium
> +	   https://bugs.webkit.org/show_bug.cgi?id=83742
> +
> +	   Expose HTMLDataListElement in the WebKitAPI.
> +	   Introduce MenuItemIDs.
> +

This patch doesn't implement the UI, do it? The summary looks not concrete.

I think adding WebDataListElement and the autofill-related changes should be
separated patches.
Also, you should explain why you'd like to make these changes in ChangeLog.

> Source/WebKit/chromium/public/WebAutofillClient.h:36
> +enum {

This should be put inside of WebAutofillClient class.

> Source/WebKit/chromium/public/WebAutofillClient.h:62
> -						int uniqueID,
> +						int itemID,

You have to update the explanation of uniqueID in the comment.

> Source/WebKit/chromium/public/WebDataListElement.h:44
> +// Provides readonly access to some properties of a DOM input element node.

input -> datalist