[webkit-reviews] review granted: [Bug 83741] Web Inspector: zoom frame on dblclick on the frame bar : [Attachment 136819] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 83741: Web Inspector: zoom frame on dblclick on the frame bar
https://bugs.webkit.org/show_bug.cgi?id=83741

Attachment 136819: Patch
https://bugs.webkit.org/attachment.cgi?id=136819&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136819&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: zoom frame on dblclick on the frame bar

This title is confusing, plesae mention the "timeline" here.

> Source/WebCore/ChangeLog:8
> +	  - put frames bars into a container, so we can have one listener

timeline frames?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:956
> +    getFramePosition: function(frame)

no get prefixes in WebKit please.