[webkit-reviews] review denied: [Bug 83634] IDL and implementation for Web Intents delivery : [Attachment 136790] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Greg Billock <gbillock at google.com>'s
request for review:
Bug 83634: IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634

Attachment 136790: Patch
https://bugs.webkit.org/attachment.cgi?id=136790&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136790&action=review


> Source/WebCore/Modules/intents/DeliveredIntent.h:67
> +    int m_intentIdentifier;

I'm not sure whether we should have identifiers at this layer.	Generally, we
prefer for the WebKit-Chromium API to be object oriented.  Any identifiers that
you need for cross-process communication should be handled in the Chromium
side.

> Source/WebCore/Modules/intents/DeliveredIntent.h:68
> +    Frame* m_frame;

This pointer can still be stale and is a security vulnerability.