[webkit-reviews] review denied: [Bug 83726] Prepare functions in LengthFunctions.h for LayoutUnits : [Attachment 136781] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 16:30:22 PDT 2012


Levi Weintraub <leviw at chromium.org> has denied Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 83726: Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726

Attachment 136781: Patch
https://bugs.webkit.org/attachment.cgi?id=136781&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136781&action=review


>> Source/WebCore/rendering/RenderFrameSet.cpp:280
>>		    remainingLen -= gridLayout[i];
> 
> is this a length?  Should this use .intValue() instead?

You are so right :)


More information about the webkit-reviews mailing list