[webkit-reviews] review denied: [Bug 83720] [Qt][WK2] Nested fixed elements scroll too fast : [Attachment 136766] Patch.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 83720: [Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720

Attachment 136766: Patch.
https://bugs.webkit.org/attachment.cgi?id=136766&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136766&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:525
> +    TextureMapperLayer* parent = m_parent;
> +    while (parent && !parent->m_fixedToViewport)
> +	   parent = parent->m_parent;
> +
> +    if (parent)
> +	   return;

Strange traversal...
How about a function isAncestorFixedToViewport() that returns true/false, and
this function calling it?

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:364
> +    if (m_fixedLayers.isEmpty())
> +	   return;
> +
> +    LayerMap::iterator end = m_fixedLayers.end();
> +    for (LayerMap::iterator it = m_fixedLayers.begin(); it != end; ++it)
> +	   toTextureMapperLayer(it->second)->setFixedToViewport(true);

This seems like a different bug/fix?