[webkit-reviews] review denied: [Bug 83432] XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox : [Attachment 136578] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 83432: XMLSerializer().serializeToString() doesn't generate the XML
declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432

Attachment 136578: Patch
https://bugs.webkit.org/attachment.cgi?id=136578&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136578&action=review


> Source/WebCore/dom/Document.h:1380
> +    StandaloneStatus m_xmlStandalone : 2;

You can't use enum in bitfields since MSVC uses signed integer for enums.
Also, bitfields won't work when different types are mixed.
You need to use unsigned for both of these fields.
r- because of this.