[webkit-reviews] review denied: [Bug 83712] Do not dereference a newly allocated JSArray if it is null : [Attachment 136735] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 13:30:40 PDT 2012


Oliver Hunt <oliver at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 83712: Do not dereference a newly allocated JSArray if it is null
https://bugs.webkit.org/show_bug.cgi?id=83712

Attachment 136735: Patch
https://bugs.webkit.org/attachment.cgi?id=136735&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The initial allocation of the JSArray must succeed -- if it didn't we would
crash in the constructor.  But also the GC guarantees allocation will work. 
tryFinishCreationUninitialized on the jsarray is the bit that may fail, and if
it fails that results in a bogus JSArray.  That's where the try... comes from.


More information about the webkit-reviews mailing list