[webkit-reviews] review denied: [Bug 16496] XMLSerializer doesn't include namespaces on nodes in HTML documents : [Attachment 136169] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 16496: XMLSerializer doesn't include namespaces on nodes in HTML documents
https://bugs.webkit.org/show_bug.cgi?id=16496

Attachment 136169: Patch
https://bugs.webkit.org/attachment.cgi?id=136169&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136169&action=review


> Source/WebCore/editing/markup.cpp:762
> +String createMarkup(const Node* node, EChildrenOnly childrenOnly,
Vector<Node*>* nodes, EAbsoluteURLs shouldResolveURLs, bool
xmlFragmentSerialization)

Please use enum instead of bool. r- because of this.

> Source/WebCore/xml/XMLSerializer.cpp:44
> +    return createMarkup(node, IncludeNode, 0, DoNotResolveURLs, true);

With enum, the semantics of this code will be much clearer.