[webkit-reviews] review granted: [Bug 83700] Web Inspector: add closure compiler annotations for profiler code : [Attachment 136678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 12:43:03 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 83700: Web Inspector: add closure compiler annotations for profiler code
https://bugs.webkit.org/show_bug.cgi?id=83700

Attachment 136678: Patch
https://bugs.webkit.org/attachment.cgi?id=136678&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136678&action=review


> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:32
> + * @param {boolean=} deferNodeContentCreation

@param should be below the @constructor and @extends

> Source/WebCore/inspector/front-end/ProfilesPanel.js:102
> + * @constructor

Annotating parameter types while you are here might make type checking more
complete.


More information about the webkit-reviews mailing list