[webkit-reviews] review denied: [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT : [Attachment 136656] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Nandor Huszka
<hnandor at inf.u-szeged.hu>'s request for review:
Bug 72841: NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841

Attachment 136656: Patch
https://bugs.webkit.org/attachment.cgi?id=136656&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136656&action=review


> Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:188
> +	       is_reftest = driver_input.should_run_pixel_test

I think this is probably wrong, and that you need to use the logic on lines
205-206 to set is_reftest, and then probably (I haven't tried this) set
should_run_pixel_tests to (self._options.pixel_tests or
driver_input.image_hash).

I don't think I have all the unit tests I need yet to make sure mock_drt
doesn't break, but I'd be curious to know if mock_drt_unittest.py actually
passes with this change? You should also do something like 'run-webkit-tests
--platform mock-mac-lion' and 'run-webkit-tests --platform mock-gtk' and make
sure the script runs to completion without any crashes or anything else weird
happening.

Note that if you can actually run these steps with this patch as-is and
everything looks right, then it's possible that I'm wrong and your patch is
right :).

The mock_drt logic is kind of subtle  and confusing, and I'm probably the only
one who's ever really used it; if it's not clear what the right changes are to
get things to work, let me know and I'll see if I can update the patch
correctly.

(And note that until very recently, all of this code was just broken anyway,
which is why you weren't getting the feedback until now).