[webkit-reviews] review denied: [Bug 83612] Split CSSStyleSheet into internal and CSSOM type : [Attachment 136708] resubmitting for bots

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 83612: Split CSSStyleSheet into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=83612

Attachment 136708: resubmitting for bots
https://bugs.webkit.org/attachment.cgi?id=136708&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review


> Source/WebCore/css/CSSStyleSheet.cpp:510
> +	   m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0);

We're gonna need a null check here, since this particular wrapper may not have
been instantiated.

> Source/WebCore/dom/ProcessingInstruction.cpp:240
> +    else if (m_isXSL)
> +	   static_cast<XSLStyleSheet*>(m_sheet.get())->parseString(sheet,
CSSStrictMode);

This looks silly, XSLStyleSheet shouldn't be taking a CSSParserMode.

> Source/WebCore/xml/XSLStyleSheet.h:74
> +    virtual bool isLoading() const;

Should add OVERRIDE while we are touching this.