[webkit-reviews] review denied: [Bug 83648] AudioContext createChannelSplitter() method should have optional argument for number of outputs : [Attachment 136631] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Raymond <rgbbones at gmail.com>'s
request for review:
Bug 83648: AudioContext createChannelSplitter() method should have optional
argument for number of outputs
https://bugs.webkit.org/show_bug.cgi?id=83648

Attachment 136631: Patch
https://bugs.webkit.org/attachment.cgi?id=136631&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136631&action=review


The change looks OK. r- due to missing tests.

>>> Source/WebCore/ChangeLog:3
>>> +	     AudioContext createChannelSplitter() method should have optional
argument for number of outputs
>> 
>> Do you have any spec that supports this change?
>> 
>> It seems the spec
(https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html) does
not have such an optional argument.
> 
> I am in the process of updating the Web Audio editor's draft.  I should be
able to get this in today.

OK. It might be good to include the link to the spec in this ChangeLog.

> Source/WebCore/ChangeLog:7
> +

Does any existing test cover this change? If so, you can write "Test: xxx.html
(No change in test results)". Otherwise, please add a test.