[webkit-reviews] review granted: [Bug 80978] [BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata : [Attachment 136617] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 80978: [BlackBerry] MMRPlayer will hang webkit thread when retrieving media
metadata
https://bugs.webkit.org/show_bug.cgi?id=80978

Attachment 136617: Patch
https://bugs.webkit.org/attachment.cgi?id=136617&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136617&action=review


LGTM. Let's wait a bit with cq+, maybe Eric has some more comments.

> Source/WebCore/ChangeLog:11
> +	   finish, and popup a dialog to notify the user what to do

and popup -> and pops up

> Source/WebCore/ChangeLog:12
> +	   if there still is no metadata when the timer fired.

fired -> fires