[webkit-reviews] review granted: [Bug 82441] [GTK] Initial cookies API for WebKit2 GTK+ API : [Attachment 134247] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 82441: [GTK] Initial cookies API for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82441

Attachment 134247: Patch
https://bugs.webkit.org/attachment.cgi?id=134247&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134247&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:210
> +   
WKCookieManagerDeleteCookiesForHostname(manager->priv->wkCookieManager.get(),
wkDomain.get());

Are the delete calls synchronous, or do we just not care about the result in
this case? Also what about deleting a single cookie? That's something Ephy does
today, something we want to keep supporting?