[webkit-reviews] review granted: [Bug 83685] Calendar Picker: remove unnecessary code from calendarPicker.{css, js} : [Attachment 136651] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 04:09:28 PDT 2012

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 83685: Calendar Picker: remove unnecessary code from

Attachment 136651: Patch

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review

> Source/WebCore/ChangeLog:12
> +	    - leading adn trailing whitespace (.js and .css)

Nit: *and*

> Source/WebCore/make-file-arrays.py:59
> +    leading_space = re.compile(r"^ ", re.MULTILINE)

This regular expression is assuming that repeating_space.sub() runs before
leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better.

> Source/WebCore/make-file-arrays.py:60
> +    trailing_space = re.compile(r" $", re.MULTILINE)

Ditto. r"[ \t]+$" might be better.

> Source/WebCore/make-file-arrays.py:75
> +	   print content

Remove this

More information about the webkit-reviews mailing list