[webkit-reviews] review granted: [Bug 83592] [Qt] InspectorServer: Improve the page list's parameter names : [Attachment 136484] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 01:23:55 PDT 2012


Simon Hausmann <hausmann at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 83592: [Qt] InspectorServer: Improve the page list's parameter names
https://bugs.webkit.org/show_bug.cgi?id=83592

Attachment 136484: Patch
https://bugs.webkit.org/attachment.cgi?id=136484&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136484&action=review


> Source/WebKit2/qt/Resources/inspectorPageIndex.html:14
> +		   var description = pages[i].title ? pages[i].title : ("Page "
+ (Number(pages[i].id)));

Wouldn't it make sense to rename the local description variable to title, too?


More information about the webkit-reviews mailing list