[webkit-reviews] review granted: [Bug 83561] [V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript : [Attachment 136586] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 11 01:11:17 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 83561: [V8] Calendar Picker: Add a helper function to expose
PagePopupClient::setValueAndClosePopup() to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=83561
Attachment 136586: Patch 2
https://bugs.webkit.org/attachment.cgi?id=136586&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. I've warmed up to this patch. If you're willing to fix the nits above and
the exception handling, then I think this is fine.
More information about the webkit-reviews
mailing list