[webkit-reviews] review granted: [Bug 83651] Ellipse and rect hit testing is clipped by the shape's bounding box : [Attachment 136602] Fix bug where stroke's bounding box was clipped

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 22:10:26 PDT 2012


Dirk Schulze <krit at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 83651: Ellipse and rect hit testing is clipped by the shape's bounding box
https://bugs.webkit.org/show_bug.cgi?id=83651

Attachment 136602: Fix bug where stroke's bounding box was clipped
https://bugs.webkit.org/attachment.cgi?id=136602&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136602&action=review


r=me with little changes.

> Source/WebCore/ChangeLog:20
> +	   I also added a FIXME to move the marker dependent code out of
> +	   RenderSVGShape entirely (which would have prevented part 2 of this
> +	   bug). Markers are only needed on a small subset of RenderSVGShape's
> +	   subclasses so that functionality should be moved out of
> +	   RenderSVGShape at some point.

And create another class that increases the call of virtual tables? Actually
there are more classes that need it than classes that don't need it. I don't
think that this fix me should go in. Rather create a new bug where we can
discuss this topic.

> Source/WebCore/rendering/svg/RenderSVGShape.h:136
> +    // FIXME: marker-dependant code should be moved into
RenderSVGShapeWithMarkers or subclasses

Like I said, I am against adding this fix me. We should discuss it on a bug
report instead of adding fixmes that are not really fixmes.

> Source/WebCore/rendering/svg/RenderSVGShape.h:137
> +    //	 that support markers (RenderSVGPath, RenderSVGLine,
RenderSVGPolygon, RenderSVGPolyLine)

no spaces here.


More information about the webkit-reviews mailing list