[webkit-reviews] review granted: [Bug 83658] [chromium] Add OVERRIDE annotations for cc layer types : [Attachment 136611] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 21:24:43 PDT 2012


Daniel Bates <dbates at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 83658: [chromium] Add OVERRIDE annotations for cc layer types
https://bugs.webkit.org/show_bug.cgi?id=83658

Attachment 136611: Patch
https://bugs.webkit.org/attachment.cgi?id=136611&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136611&action=review


> Source/WebKit/chromium/ChangeLog:14
> +	   * src/WebLayerImpl.cpp:
> +	   * src/WebLayerImpl.h:

For your consideration I suggest adding a remark to the right of these files to
explain that you are removing the function WebLayerImpl::paintContents()
instead of adding an override annotation to it.


More information about the webkit-reviews mailing list