[webkit-reviews] review denied: [Bug 81854] RadioNodeList support in HTMLFormElement::elements : [Attachment 136614] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 81854: RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Attachment 136614: Updated patch
https://bugs.webkit.org/attachment.cgi?id=136614&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136614&action=review


> Source/WebCore/html/RadioNodeList.cpp:39
> +    : DynamicSubtreeNodeList(forNode->hasTagName(formTag) ?
forNode->document() : forNode)

This condition is not needed at the moment since we don't implement one for
html fieldset elements.
r- due to this over-generalization.

> Source/WebCore/html/RadioNodeList.cpp:93
> +    if (m_forNode->hasTagName(formTag)) {

Also, this should always be true for now.