[webkit-reviews] review granted: [Bug 82990] REGRESSION (r111456): overflow-scrolling and css clip break with compositing : [Attachment 136588] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 82990: REGRESSION (r111456): overflow-scrolling and css clip break with
compositing
https://bugs.webkit.org/show_bug.cgi?id=82990

Attachment 136588: Patch
https://bugs.webkit.org/attachment.cgi?id=136588&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136588&action=review


> Source/WebCore/rendering/RenderLayer.cpp:4718
> +	   compositor()->setCompositingLayersNeedRebuild();

Does this end up doing just a geometry update, or does it do a full hierarchy
update?

> LayoutTests/compositing/clip-change.html:35
> +	 if (window.layoutTestController)
> +	   layoutTestController.display();
> +	 // The change in clip style should be reflected immediately in the
size
> +	 // of the composited clipper layer. After changing the clip, it should

> +	 // entirely cover the indicator.
> +	 var clipper = document.getElementById("clipper");
> +	 clipper.style.clip = "rect(0px, 100px, 100px, 0px)";
> +    }

I think that tests that call display() to get layers to be updated don't always
work correctly in Safari (which we should fix).