[webkit-reviews] review denied: [Bug 83545] Stack overflow in CSS parser caused by recursive stylesheet import : [Attachment 136581] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 17:40:15 PDT 2012


Darin Adler <darin at apple.com> has denied David Barr <davidbarr at chromium.org>'s
request for review:
Bug 83545: Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Attachment 136581: Patch
https://bugs.webkit.org/attachment.cgi?id=136581&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136581&action=review


> Source/WebCore/css/CSSImportRule.cpp:-141
> -	   // FIXME: This is wrong if the finalURL was updated via
document::updateBaseURL.

This FIXME doesn’t seem to be for the bug you’re fixing, so please don’t remove
it.


More information about the webkit-reviews mailing list