[webkit-reviews] review granted: [Bug 83604] Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage : [Attachment 136508] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 83604: Clean up multiple RenderedPosition::absoluteRect definitions and
correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604

Attachment 136508: Patch
https://bugs.webkit.org/attachment.cgi?id=136508&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136508&action=review


> Source/WebCore/editing/RenderedPosition.cpp:232
> +    IntRect localRect =
pixelSnappedIntRect(m_renderer->localCaretRect(m_inlineBox, m_offset,
extraWidthToEndOfLine));

For people watching at home, the pixelSnappedIntRect confused me a lot and I
pinged leviw@ about that. Currently we want to snap our rectangles before
calling localToAbsoluteQuad to be consistent across all the painting code.

We may lose some precision by doing so (if we have a transform that is not
pixel aligned for example), but coherency is better for now. We may relax this
requirement later.