[webkit-reviews] review denied: [Bug 83545] Stack overflow in CSS parser caused by recursive stylesheet import : [Attachment 136396] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied David Barr
<davidbarr at chromium.org>'s request for review:
Bug 83545: Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Attachment 136396: Patch
https://bugs.webkit.org/attachment.cgi?id=136396&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136396&action=review


Not sure what "checkpointing" means in this context, but this is clearly the
kind of fix that needs regression tests.

> Source/WebCore/css/CSSImportRule.cpp:141
>	   // FIXME: This is wrong if the finalURL was updated via
document::updateBaseURL.

Is this FIXME still accurate?