[webkit-reviews] review requested: [Bug 83587] [Qt] Fix issues when using the WebView as ShaderEffectSource : [Attachment 136495] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 10 11:33:39 PDT 2012
Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked for review:
Bug 83587: [Qt] Fix issues when using the WebView as ShaderEffectSource
https://bugs.webkit.org/show_bug.cgi?id=83587
Attachment 136495: Patch
https://bugs.webkit.org/attachment.cgi?id=136495&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Using PaintingFlag instead of a mirrored bool.
It felt a bit stretched to use the generic flag in the createProjectionMatrix
static method so I leaved it as before but used const bools for the mirrored
parameter in callers.
More information about the webkit-reviews
mailing list