[webkit-reviews] review granted: [Bug 82476] Extra display logic for the media control panel element : [Attachment 136489] Updated test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 11:15:30 PDT 2012

Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<vcarbune at adobe.com>'s request for review:
Bug 82476: Extra display logic for the media control panel element

Attachment 136489: Updated test.

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136489&action=review

> LayoutTests/media/video-controls-toggling.html:58
> +	       if (panel.style['display'] != 'none') {
> +		   setTimeout(continueTest, fadeoutTime);
> +		   return;
> +	       }

The only problem with this is that it will set the timer again and again until
the test is killed, so it might be better to only do this once. On the other
hand, the test will timeout eventually so this might be OK. Your call.

More information about the webkit-reviews mailing list