[webkit-reviews] review granted: [Bug 83431] Cleanup wtf/Platform.h and config.h files : [Attachment 136150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 11:05:50 PDT 2012


Eric Seidel <eric at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83431: Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431

Attachment 136150: Patch
https://bugs.webkit.org/attachment.cgi?id=136150&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Thanks!  I think there have been different visions at different times about
what belongs in config.h vs. platform.	I also think that some folks might
argue it's nice to have all the #defin foo 0' around so we know what we can set
to 1.  But I like your cleanup.  I like simpliflying these files, and I'm glad
someone is finally looking at it!


More information about the webkit-reviews mailing list