[webkit-reviews] review granted: [Bug 83574] [CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro : [Attachment 136445] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83574: [CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
https://bugs.webkit.org/show_bug.cgi?id=83574

Attachment 136445: Patch
https://bugs.webkit.org/attachment.cgi?id=136445&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review


> Source/cmake/WebKitMacros.cmake:192
> +    SET(_doing_directories 0)
> +    SET(_doing_files 0)

These names are OK as-as. Maybe the prefix "_processing_" would be somewhat
more descriptive than the prefix "_doing_".  That being said, both "processing"
and "doing" are somewhat vague terms.

> Source/cmake/WebKitMacros.cmake:198
> +	   STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content})

Can we make this regular expression stronger? In particular, would substituting
[^"] instead of (.*) help strengthen this? Can we also match the
newline/end-of-line character '$'?