[webkit-reviews] review granted: [Bug 83590] Update cmakeconfig.h.in after r113570 : [Attachment 136486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 10:36:23 PDT 2012


Daniel Bates <dbates at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83590: Update cmakeconfig.h.in after r113570
https://bugs.webkit.org/show_bug.cgi?id=83590

Attachment 136486: Patch
https://bugs.webkit.org/attachment.cgi?id=136486&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review


> Source/cmakeconfig.h.cmake:-15
> -#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION

According to <https://bugs.webkit.org/show_bug.cgi?id=82594#c4> this is still
used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is used by the BlackBerry port. (Added in changeset 112654;
<http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>)

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.


More information about the webkit-reviews mailing list