[webkit-reviews] review requested: [Bug 32021] DRT's textInputController is unimplemented on Windows : [Attachment 136482] implementation for TextInputController on windows port

[bugzilla-daemon at webkit.org]

Lynn Neir <lynn.neir at skype.net> has asked  for review:
Bug 32021: DRT's textInputController is unimplemented on Windows
https://bugs.webkit.org/show_bug.cgi?id=32021

Attachment 136482: implementation for TextInputController on windows port
https://bugs.webkit.org/attachment.cgi?id=136482&action=review

------- Additional Comments from Lynn Neir <lynn.neir at skype.net>
This patch contains implementation for TextInputController in DRT that works on
Windows port.

A number of tests have been effected, here are the details about the tests:

These two tests now pass match mac baseline and so old baselines in windows
port were removed:
 fast/forms/input-maxlength-ime-completed.html --> removed old baseline in
windows port - no longer needed as test now passes fine.
 fast/forms/input-maxlength-ime-preedit.html --> removed old baseline in
windows port - no longer needed as test now passes fine.

These nine tests now pass and so were removed from windows port Skipped file:
 editing/input/ime-composition-clearpreedit.html
 editing/input/password-echo-textnode.html 
 editing/input/password-echo-passnode.html 
 editing/input/password-echo-passnode2.html 
 editing/input/password-echo-passnode3.html 
 editing/input/setting-input-value-cancel-ime-composition.html 
 editing/inserting/insert-composition-whitespace.html
 fast/dom/tab-in-right-alignment.html
 fast/text/international/thai-cursor-position.html

The results for these six tests are correct now but do not match mac baseline
because mac uses flipped coordinate system, so baselines in windows port were
added/updated:
 editing/selection/5825350-1.html 
 editing/selection/5825350-2.html 
 editing/selection/mixed-editability-10.html
 editing/selection/move-left-right.html
 editing/inserting/caret-position.html
 svg/text/caret-in-svg-text.xhtml

The result for this test does not match mac baseline but does match result for
WebKitTestRunner on windows port, so updated windows port baseline:
 fast/events/ime-composition-events-001.html