[webkit-reviews] review denied: [Bug 83565] Crash when reloading page while it is loading : [Attachment 136433] Patch to fix possible null pointer dereference

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Jonathan Liu <net147 at gmail.com>'s
request for review:
Bug 83565: Crash when reloading page while it is loading
https://bugs.webkit.org/show_bug.cgi?id=83565

Attachment 136433: Patch to fix possible null pointer dereference
https://bugs.webkit.org/attachment.cgi?id=136433&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136433&action=review


> Source/WebCore/loader/ResourceLoader.cpp:385
> -
> -	   m_documentLoader->cancelPendingSubstituteLoad(this);
> +	   if (m_documentLoader)
> +	       m_documentLoader->cancelPendingSubstituteLoad(this);

We don't typically null-check ResourceLoader::m_documentLoader. The preferred
technique is to check m_reachedTerminalState, which should catch every case
where m_documentLoader is null.

It would be great if we had a layout test for this. At the very least, we
should figure out where in here we're calling releasedResources(), which nulls
m_documentLoader and sets m_reachedTerminalState to true.