[webkit-reviews] review granted: [Bug 82353] msqrt's implied mrow should do operator stretching : [Attachment 136393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 08:39:27 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 82353: msqrt's implied mrow should do operator stretching
https://bugs.webkit.org/show_bug.cgi?id=82353

Attachment 136393: Patch
https://bugs.webkit.org/attachment.cgi?id=136393&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136393&action=review


r=me.

> Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:69
> +	   return result + (style()->isLeftToRightDirection() ?
m_intrinsicPaddingStart : m_intrinsicPaddingEnd);

AFAICT the parentheses around the ternary '?' operator are unneeded here as it
has lower priority and we usually omit them.


More information about the webkit-reviews mailing list