[webkit-reviews] review denied: [Bug 83248] [BlackBerry] Upstream the BlackBerry change to rendering/RenderPart.cpp : [Attachment 135965] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 08:28:42 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 83248: [BlackBerry] Upstream the BlackBerry change to
rendering/RenderPart.cpp
https://bugs.webkit.org/show_bug.cgi?id=83248

Attachment 135965: Patch v2
https://bugs.webkit.org/attachment.cgi?id=135965&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Sorry, Leo, but I do not want to add a #if plat(bb) here like this. I would
suggest:

- make a helper with a meaningful name, and add if's there. Maybe even a static
local function.
- add a setting, where bb is the only platform that default returns false.

also it would be good to mention where in the code blackberry port we HW
accelerate plugin layers, etc.


More information about the webkit-reviews mailing list