[webkit-reviews] review granted: [Bug 80978] [BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata : [Attachment 136391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 07:19:16 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 80978: [BlackBerry] MMRPlayer will hang webkit thread when retrieving media
metadata
https://bugs.webkit.org/show_bug.cgi?id=80978

Attachment 136391: Patch
https://bugs.webkit.org/attachment.cgi?id=136391&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136391&action=review


Looks good, nice that a test can be added, please fix the typo's before
landing.

> Source/WebCore/ChangeLog:10
> +	   which starts a timer to wait for the metadata retriving

Typo retrieving.

> Source/WebCore/ChangeLog:11
> +	   finish, and popup a dialog to notify user what to do

"to finish", "the user"

> Source/WebCore/ChangeLog:12
> +	   if still haven't get metadata when timer fired. This won't

"if still haven't get metadata" -> "if there still is no metadata"

> Source/WebCore/ChangeLog:13
> +	   block the webkit thread as what we used to do in platform repo.

please rephrase the last sentence, it is not completely clear to me what you
mean.

> LayoutTests/ChangeLog:11
> +	   webkit thread is blocked by media retriving thread.

Typo retrieving.


More information about the webkit-reviews mailing list