[webkit-reviews] review granted: [Bug 81143] [Qt][WK2] Implement PageClient::isViewWindowActive() : [Attachment 133579] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jesus
Sanchez-Palencia <jesus at webkit.org>'s request for review:
Bug 81143: [Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143

Attachment 133579: Patch
https://bugs.webkit.org/attachment.cgi?id=133579&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133579&action=review


> Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:83
> +    // QWindow does not create the underlying platform
> +    // specific bits unless QWindow::setVisible() or QWindow::show() are
called,
> +    // and without it QWindow::isActive() will always return false.
> +    // For these cases QWindow::create() is provided.

// QWindow delays creating of the underlying platform specific bits until
::setVisible()
// or ::show() are called. This makes ::isActive() always return false. In
order to force
// the creation ::create() exists, so we use it here.