[webkit-reviews] review requested: [Bug 83562] [CMake] CMake SVG Code Generation fails to generate code for extra defines : [Attachment 136436] Fixing CMake build wrt SVG code generation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 05:42:35 PDT 2012


Dominik Röttsches <dominik.rottsches at linux.intel.com> has asked  for review:
Bug 83562: [CMake] CMake SVG Code Generation fails to generate code for extra
defines
https://bugs.webkit.org/show_bug.cgi?id=83562

Attachment 136436: Fixing CMake build wrt SVG code generation
https://bugs.webkit.org/attachment.cgi?id=136436&action=review

------- Additional Comments from Dominik Röttsches
<dominik.rottsches at linux.intel.com>
(In reply to comment #8)
> (From update of attachment 136434 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=136434&action=review
> 
> > Source/WebCore/CMakeLists.txt:2585
> > +SET(SVG_EXTRA_DEFINES, "")
> 
> missed a point: comma after SVG_EXTRA_DEFINES

Thanks. Fixed.


More information about the webkit-reviews mailing list